Added Support for ESP32-C3 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes were only tested on a XIAO-ESP32-C3. This should solve problem #20. After some testing I found out that ledc only work down to 200Hz on the ESP32-C3.
|
Are there no way to support lower frequencies than 200 Hz on C3? |
|
The library in v1.1.0 has a new parameter Without that, we would need to add define for each new ESP32 chip, which is not such practical. Now users can set the frequency like this: Servo servo1;
const int servoPin = 4;
const int frequency = 200; // Hz
servo1.attach(
servoPin,
Servo::CHANNEL_NOT_ATTACHED,
Servo::DEFAULT_MIN_ANGLE,
Servo::DEFAULT_MAX_ANGLE,
Servo::DEFAULT_MIN_PULSE_WIDTH_US,
Servo::DEFAULT_MAX_PULSE_WIDTH_US,
frequency
);@EinRainerZufall Let me know if you are ok with this solution, and we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes were only tested on a XIAO-ESP32-C3.
This should solve problem #20 .
After some testing I found out that ledc only work down to 200Hz on the ESP32-C3.
I have also added the solution @h2zero in #18 for the bit deep